fix(web): fix composer mention menu highlight and scroll#1285
Open
GuilhermeVieiraDev wants to merge 4 commits intopingdotgg:mainfrom
Open
fix(web): fix composer mention menu highlight and scroll#1285GuilhermeVieiraDev wants to merge 4 commits intopingdotgg:mainfrom
GuilhermeVieiraDev wants to merge 4 commits intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
vouch:unvouched
GuilhermeVieiraDev
changed the title
github-actions
bot
added
size:M
GuilhermeVieiraDev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Fixed the composer
@mention menu so keyboard navigation keeps the highlighted item in view.Also restored a single visible highlight owner for the menu. The active item is now the only item that gets highlighted visually, which fixes the duplicate-highlight behavior where one item could stay visually selected while another became active from keyboard navigation.
Why
The
@mention picker had two related issues:ArrowDown/ArrowUpcould move the active item without scrolling the menu, so the real selection could end up outside the visible area.This change keeps the visible highlight ownership in one place and adds scroll sync on the active item, which makes keyboard navigation behave like a normal command menu again.
UI Changes
Before:
Screencast.From.2026-03-21.21-48-42.mp4
After:
Screencast.From.2026-03-21.21-50-58.mp4
Checklist
Note
Fix composer mention menu highlight tracking and scroll-into-view behavior
Command's built-in highlight logic inComposerCommandMenuwith parent-controlled state, passingautoHighlight={false},keepHighlight={false}, andhighlightItemOnHover={false}to prevent conflicts.useEffectthat callsscrollIntoView({ block: 'nearest' })on the active item element wheneveractiveItemIdchanges, keeping the highlighted entry visible during keyboard navigation.data-activeanddata-pathattributes and fireonHighlightedItemChangeononMouseMoveso hover and keyboard navigation stay in sync.ChatView.browser.tsxthat seeds project entries, simulatesArrowDownpresses, and assertsscrollIntoViewis called and the selected path is inserted into the draft prompt.Macroscope summarized 9c7c97b.